From 06a2396fe439165028e666deffae851447c24a45 Mon Sep 17 00:00:00 2001 From: Ava Wroten Date: Mon, 16 Mar 2020 11:19:56 -0500 Subject: [PATCH] Presentation adjustments --- presentation/index.html | 134 +++++++++++++++++++++++++++++++++------- 1 file changed, 111 insertions(+), 23 deletions(-) diff --git a/presentation/index.html b/presentation/index.html index 1f3de5d..f29e99c 100644 --- a/presentation/index.html +++ b/presentation/index.html @@ -68,6 +68,10 @@ Or Github @sharpshark28

+ +
@@ -78,10 +82,14 @@

A project feature saved by A11y

+ +
@@ -94,7 +102,7 @@

What about A11y?

@@ -102,13 +110,17 @@

A11Y

A....11.....Y

Accessibility

+ +

Equity

@@ -126,6 +138,10 @@ + +
@@ -139,6 +155,7 @@
@@ -166,13 +183,18 @@

W3C Pattern Rearrangable Listbox

+

ember-sortable on ember observer

+ +
@@ -207,6 +229,32 @@ ``` + + +
+ +
+

Composed Components

+ +

+ index.hbs +

+ +
+ ```html.hbs + <SortableGroupAccessible> + <SortableGroup> + {{#each this.items as | item |}} + <SortableItem> + <MyItemComponent /> + </SortableItem> + {{/each}} + </SortableGroup> + </SortableGroupAccessible> + ``` +
@@ -217,11 +265,19 @@

https://gitlab.com/gaiety/sortable-recipes

+ +

Implementation Details

https://gitlab.com/gaiety/sortable-recipes

+ +
@@ -262,7 +318,7 @@
@@ -281,34 +337,45 @@ {{key-up this.handleArrowDown key='ArrowDown'}} -

- modifiers/key-up.js -

+
+

+ modifiers/key-up.js +

-

-            import { modifier } from 'ember-modifier';
-            const listener = (evt) => {
-              if (!desiredKey || desiredKey === evt.key) handler(evt);
-            }
-            export default modifier(function keyUp(element, [handler], { key: desiredKey }) {
-              element.addEventListener('keyup', listener);
-              return () => { element.removeEventListener('keyup', listener); }
-            });
-          
+

+              import { modifier } from 'ember-modifier';
+              const listener = (evt) => {
+                if (!desiredKey || desiredKey === evt.key) handler(evt);
+              }
+              export default modifier(function keyUp(element, [handler], { key: desiredKey }) {
+                element.addEventListener('keyup', listener);
+                return () => { element.removeEventListener('keyup', listener); }
+              });
+            
+
+ + +
+

Testing Details

@ember/test-helpers

+ +
-

Modifier Tests

+

Modifier Rendering Tests

modifiers/key-up-test.js @@ -317,8 +384,8 @@


             test('it can listen for specific key up events', async function(assert) {
               this.keyUp = ({ key }) => {
-                assert.step('key up');
                 assert.equal(key, 'Enter');
+                assert.step('key up');
               };
               await render(hbs`
                 <div {{key-up this.keyUp}} data-test-id='keyup'></div>`);
@@ -327,10 +394,14 @@
               assert.verifySteps(['key up']);
             });
           
+ +
-

Testing Reordering

+

Application Testing Reordering

index-test.js @@ -350,6 +421,10 @@

🎉 A11y allowed us to test reordering! 🎉 + +
@@ -368,10 +443,18 @@
  • Less stress on QA
  • Less scope creep
  • + +

    v2.x.x ember-sortable

    + +
    @@ -381,6 +464,7 @@
  • A11y Screen Announcements
  • ember-sortable v2.2.x modifiers
  • ember-a11y-testing
  • +
  • ember-cli-template-lint
  • @@ -398,6 +482,10 @@

    Allovue

    We are hiring!

    + +