From 9624cf6acd75af17d669c592a0391f82ed9e91f9 Mon Sep 17 00:00:00 2001
From: Liam <31192478+terror@users.noreply.github.com>
Date: Fri, 24 Jul 2020 03:37:09 -0400
Subject: [PATCH] fix: stats hide_border bug (#151)

* fix: stats hide border bug

* fix white border on dark mode issue

* chore: refactor code & tests

Co-authored-by: anuraghazra <hazru.anurag@gmail.com>
---
 src/renderStatsCard.js        |  5 ++---
 tests/renderStatsCard.test.js | 10 +++++++++-
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/src/renderStatsCard.js b/src/renderStatsCard.js
index 416ce53..85f5b77 100644
--- a/src/renderStatsCard.js
+++ b/src/renderStatsCard.js
@@ -130,9 +130,7 @@ const renderStatsCard = (stats = {}, options = { hide: [] }) => {
     ? ""
     : `<text x="25" y="35" class="header">${name}'${apostrophe} GitHub Stats</text>`;
 
-  const border = hide_border
-    ? ""
-    : `
+  const border = `
     <rect 
       data-testid="card-bg"
       x="0.5"
@@ -142,6 +140,7 @@ const renderStatsCard = (stats = {}, options = { hide: [] }) => {
       rx="4.5"
       fill="${bgColor}"
       stroke="#E4E2E2"
+      stroke-opacity="${hide_border ? 0 : 1}"
     />
   `;
 
diff --git a/tests/renderStatsCard.test.js b/tests/renderStatsCard.test.js
index eaec45f..caa3167 100644
--- a/tests/renderStatsCard.test.js
+++ b/tests/renderStatsCard.test.js
@@ -71,8 +71,16 @@ describe("Test renderStatsCard", () => {
 
   it("should hide_border", () => {
     document.body.innerHTML = renderStatsCard(stats, { hide_border: true });
+    expect(queryByTestId(document.body, "card-bg")).toHaveAttribute(
+      "stroke-opacity",
+      "0"
+    );
 
-    expect(queryByTestId(document.body, "card-bg")).not.toBeInTheDocument();
+    document.body.innerHTML = renderStatsCard(stats, { hide_border: false });
+    expect(queryByTestId(document.body, "card-bg")).toHaveAttribute(
+      "stroke-opacity",
+      "1"
+    );
   });
 
   it("should hide_rank", () => {